In theory we should have used profiles settings for this, providing a proper unity.ini
But right now there's no reason for that effort.
In case someone wants to change settings, profiles will fix this.

In theory we should have used profiles settings for this, providing a proper unity.ini
But right now there's no reason for that effort.
In case someone wants to change settings, profiles will fix this.

Need to revert rev. 3798 because it has a bad side effect of "hanging" all of the windows when restarting Compiz and rendering the desktop unusable.

also minor improvement in syntax

The decorator draws a normal border around semi-maximized windows. When
maximized border extents were used for semi-maximized windows, compiz didn't
reserve any space for the border in its geometry calculations.

At least following problems are a result of this behavior:
- Semi-maximized windows have 1px borders drawn on adjacent workspaces
  (LP: #986051).
- Grid placed window overlaps the adjacent viewport (LP: #898870).

Further ensure that the window decoration isn't needlessly reset if the
window already had one.

Refactored XShape usage into a common function.

Added tests to verify the behaviour of shape set on initially creating
a decorated window and also upon changing the input frame window shape

(LP: #1158267)

DecorPixmapShapeSetAcceptance.FrameWindowShapeIsUpdated fails because
we never query the window shape when it isn't set by the decorator on
first run

DecorPixmapShapeSetAcceptance.FrameWindowShapeIsUpdated fails because
we never actually catch the ShapeNotify from the decoration.

1. Always set frame extents before updating the frame
2. Added COMPIZ_NO_CONFIGURE_BUFFER_LOCKS so that we don't have to deal
   with the delayed configure requests logic in the tests where it
   does not help
3. Split restoredDecorationSize in to restoredDecorationBorderSize
   and restoredDecorationInputSize so that we can measure the size of
   the decoration both in terms of its visible and invisible border
4. Wait for the default decoration properly
5. Capture the initial geometry of the window with and without decorations
   when the window gets its first decoration. Use these values to calculate
   the size changes in the window from then on instead of its creation
   values
6. Just flag when the window was first decorated in setWindowFrameExtents
   rather than checking if it is mapped. We only want to not resize
   the window once.

1. Completely remove decorOffsetMove and other related code from
   decor.cpp. Put the logic to handle the window->input () - window->border ()
   placement offset inside of setWindowFrameExtents instead. Now the window
   will always be offset from its original non-decorated position to the new
   decorated position, rather than having to guess between decoration sizes.
2. Make saveGeometry and restoreGeometry work relative to window->border ()
   as opposed to including it in the saved geometry. It is possible that the
   border size might change during maximization, as such, we don't want to
   save the position with the border before maximizing. Instead save the position
   as if it were never decorated so that when the window is restored it can be
   restored to its original position and then adjusted for its new border size.
3. Fix a few typoes in the tests.
4. Moved some commonly used matchers into compiz::testing
5. Make COMPIZ_PLUGIN_DIR accept multiple directories and look in each one
   of them for the plugin
6. Set COMPIZ_PLUGIN_DIR appropriately for each plugin that we wish to load
   on startup so that we load locally built plugins as opposed to installed
   ones.
7. Uncomment compiz_discover_tests for the acceptance tests. Now they are
   run by default.

 1. Stop repeating ConfigureNotifyXEventMatcher and co everywhere, just
    have a WaitForConfigureOn wrapper function to simplify that from
    14 lines per use to 5 lines per use.
 2. Added ReconfigureDecoration as a means to change a pixmap decoration's
    border and input at the same time whilst also waiting for the frame
    window to be adjusted.
 3. Saved the result of XInternAtom where it made sense.

PixmapDecoratedWindowAcceptance.
  UndecoratedWindowExpandToOrigSize

    Test that upon undecoration, the window has exactly the same geometry
    as it did before decoration.

  DISABLED_UndecorateStaticGravityWindow

    Tests that for windows with a static gravity, the window has exactly
    the same geometry as it did before decoration.

    Disabled, as core is currently not moving the window with the static
    gravity back to where it started.

AdjustmentExtents/PixmapDecorationAdjustment.
  AdjustRestoredWindowBorderMovesClient/P

    Test that changing the border extents causes the client window's
    absolute geometry to change.

  DISABLED_AdjustRestoredWindowBorderShrinkClient/P

    Tests that changing the border extents causes the client window's
    absolute geometry to shrink by the amount of border.

    Disabled, as the current behavior is to expand the frame window
    as opposed to shrinking the client (but this will be changed).

  DISABLED_ClientExpandsAsBorderShrinks/P

    Tests that as the border shrinks away, the client expands back to
    its original size.

    Disabled, as the current behavior is to expand the frame window 
    as opposed to shrinking the client (but this will be changed).

  DISABLED_ClientExpandsAsBorderShrinksWhilstMaximized/P

    Tests that even if the client is maximized, if the restored border
    shrinks away it demaximizes back to the same position while also
    accounting for any change in the restored window border size.

    Disabled, as the current behavior is to expand the frame window 
    as opposed to shrinking the client (but this will be changed).

  DISABLED_ClientExpandsAsBorderShrinksWhilstUndecorated/P

    Tests that even when the client is not permitted to be decorated
    because the decoration hint was removed, when it is redecorated
    it will be moved to the correct position taking into account any
    changes in its border size.

    Disabled, as the current behavior is to expand the frame window 
    as opposed to shrinking the client (but this will be changed).

  DISABLED_AdjustRestoredWindowInputNoMoveClient/P

    Tests that adjusting the input extents (as independent from the
    border extents) of the client does not cause the client to move.

    Disabled, as this behavior appears to be broken in core.

Move the "GetImmediateParent" function into the compiz::testing namespace
so that it can be used by other tests.

plugins that haven't yet been installed.

This change provides a simple acceptance test suite for the decor plugin. It
creates a fake window decorator (cdt::FakeDecorator) and allows users to
create fake decorations (eg cdt::FakePixmapDecoration) which can be serialized
as decoration properties and set on windows under xorg-gtest. It also launches
compiz with the opengl, composite and decor plugins loaded and runs some
basic tests. Among them:

BaseDecorAcceptance.
  Startup:

    Basic canary "can we start compiz with these plugins" test

  FakeDecoratorSessionOwnerNameSetOnSelectionOwner:

    Create a fake decorator, ensure that libdecoration sets our
    session name "fake" on the selection owner

  FakeDecoratorReceiveClientMessage:

    Create fake decorator, ensure that libdecoration posts a client
    message to the root window announcing that the new decorator exists.

  DecorationSupportsWindowType:

    Create a fake decorator, announce support for the WINDOW type decorations
    and ensure that the correct atom is set on the session owner window.

  DecorationSupportsPixmapType:

    Create a fake decorator, announce support for the PIXMAP type decorations
    and ensure that the correct atom is set on the session owner window.

DecorFakeDecoratorAcceptance.
  WindowDefaultFallbackNoExtents:

    By default, newly created windows should recieve a fallback decoration
    but they should not have any frame extents.

DecorWithPixmapDefaultsAcceptance.

  These tests create a default pixmap decoration to use in the hypothetical
  situation that the window decorator hasn't yet generated a decoration
  for this window.

  FallbackRecieveInputFrameNotify:

    Verify that we get a _COMPIZ_WINDOW_DECOR_INPUT_FRAME property set on
    the client when it is created and mapped (eg, an input frame window
    was annonuced to be created)

  FallbackHasInputFrameInParent:

    Verify that a second window exists in the frame window after this
    message was recieved.

  FallbackNormalWindowExtentOnDecoration:

    Verify that _NET_FRAME_EXTENTS is set to the default window extents
    for the default decoration when the window was mapped.

  FallbackNormalWindowInputOnFrame:

    Verify that the input window matches the extents set.

PixmapDecoratedWindowAcceptance.

  These tests create a new window and an associated unique decoration for
  that window.

  MaximizeBorderExtentsOnMaximize:

    Maximize the window and ensure that the correct border extents are used.

  MaximizeBorderExtentsOnVertMaximize:

    Vertically maximize the window and ensure that the correct border extents
    are used.

  MaximizeBorderExtentsOnHorzMaximize:

    Horizontally maximize the window and ensure that the correct border
    extents are used.

  MaximizeFrameWindowSizeEqOutputSize:

    Maximie the window and ensure that the frame window exactly equals
    the output size.

  VertMaximizeFrameWindowSizeEqOutputYHeight:

    Maximize the window and ensure that the frame window's Y and Height
    values are consistent with the output size.

  HorzMaximizeFrameWindowSizeEqOutputXWidth:

    Ditto horizontal maximization.

  DISABLED_VertMaximizeFrameWindowSizeSameXWidth:

    Maximize the window vertically and ensure that the frame window's
    border-relative X position and width does not change.

    This test is disabled, as the behavior in compiz is currently broken,
    (but it means that we can fix it later and enable the test).

  DISABLED_HorzMaximizeFrameWindowSizeSameYHeight

    Maximize the window horizontally and ensure that the frame window's 
    border-relative Y position and height does not change.

    This test is disabled, as the behavior in compiz is currently broken,
    (but it means that we can fix it later and enable the test).

This is effectively a bundle of fixes in one:

1. Don't adjust maximized windows after their decorations change with
   addWindowSizeChanges. That only needs to be done on initial maximization
   and then any other decoration size change can handle itself
2. Don't cause the saved co-ordinates to be updated upon unmaximization
3. Don't put the decoration adjustment on a timer. Do it immediately.
   The calling WindowInterface::moveNotify from within itself is no
   longer a problem.

(LP: #1186560)

to record changes in decoration shift even for non-placed windows (even if
we don't move them ourselves).

Provide our own compiz_xorg_gtest_main and subclass xorg::testing::Environment
to try and launch tests on another display if there's tests running on
one already.

This isn't by any means perfect - there are still race conditions
surrounding XOpenDisplay and parallel test runs but it makes any
time gap for conditions such as:
 1. Client has a server grab on the display we're checking
    and won't let go.
 2. Two servers get launched on one port and one set of tests
    interfere with the other.

It also means that we're now unable to configure the display port,
log file and config file on the command line. But we weren't using that
anyways.

Finally, the logs now point to /tmp/Compiz.Xorg.GTest.displaynum.log

(LP: #1178514)

	included in everything.

  
  Previously when a window was undecorated, we would shift it back to an appropriate position
  according to its gravity member. That behaviour was problematic because in the StaticGravity
  case the window has to just stay in the same place. But then if you had a window with StaticGravity
  which then did get a decoration and later removed it, it would be placed as though it was
  decorated and appear to be in the wrong place.
  
  The correct behaviour is to place all windows as though they have decorations, and then when
  decorations are removed, to move the window back to the corner as indicated in its gravity
  and then expand its size to cover the obscured regions no longer hidden because the decorations
  went away.
  
  The spec is unfortunately not so clear what to do in this case. But KWin does it this way
  and it seems to be the sanest way of doing it.
  
  (LP: #1165343)

from allowing shadow-only windows to enter into the update function

This allows us to set frame extents and not set the whole decoration
property

need it for the downcast situation (which in itself is a little silly)

(LP: #1131864)

(LP: #1056409)

use the xorg_gtest wrappers