Skip to content
  1. Sep 18, 2012
  2. Sep 17, 2012
    • Sam Spilsbury's avatar
      Actually provide the hint · 28218d3d
      Sam Spilsbury authored
      28218d3d
    • Sam Spilsbury's avatar
      Bump ABI · b356b116
      Sam Spilsbury authored
      b356b116
    • Sam Spilsbury's avatar
      Check that pixmaps which aren't managed by us actually exist before binding. · e31cee80
      Sam Spilsbury authored
      It was possible for there to be a race condition for a pixmap to become
      invalid on the server side if the client which did have control over thier
      lifecycle freed them before we were done with them or disconnected. Drivers
      have normally handled this condition by reading the contents of the undefined
      memory directly without an error, however drivers such as LLVMpipe will
      effectively dereference an invalid pointer and crash when you do this.
      
      Eg:
      
      compiz crashed with SIGSEGV in memmove() from drisw_update_tex_buffer() from dri_set_tex_buffer2() from drisw_bind_tex_image() from __glXBindTexImageEXT() from TfpTexture::enable()
      
      Most of the time we don't need to employ this check. Its only when we know
      that we don't control the lifecycle of a pixmap that race conditions
      such as these can occurr.
      e31cee80
    • Sam Spilsbury's avatar
      Make the tests pass · d07d71fb
      Sam Spilsbury authored
      d07d71fb
    • Sam Spilsbury's avatar
      Walking skeleton for glx tfp bind code, failing tests: · 1ef73a20
      Sam Spilsbury authored
      [  FAILED  ] CompizOpenGLGLXTextureFromPixmapBindTest.TestTakesServerGrab
      [  FAILED  ] CompizOpenGLGLXTextureFromPixmapBindTest.TestNoCallToCheckValidityIfInternalAndImmediateBind
      [  FAILED  ] CompizOpenGLGLXTextureFromPixmapBindTest.TestCheckValidityIfExternalNoBindIfInvalid
      [  FAILED  ] CompizOpenGLGLXTextureFromPixmapBindTest.TestCheckValidityIfExternalBindIfValid
      1ef73a20
  3. Sep 15, 2012
  4. Sep 14, 2012
  5. Sep 13, 2012
  6. Sep 12, 2012
  7. Sep 11, 2012
  8. Sep 10, 2012