- Jul 22, 2013
-
-
Sam Spilsbury authored
-
- Jul 21, 2013
-
-
Sami Jaktholm authored
(LP: #1090713). Fixes: https://bugs.launchpad.net/bugs/1090713. Approved by PS Jenkins bot, MC Return, Sam Spilsbury.
-
MC Return authored
Introduced const float halfPi = PI / 2.0f; and const float triHalfPi = halfPi * 3; and used those to draw the rounded background. Introduced GLfloat xPlusWidth = x + width; and GLfloat yMinusHeight = y - height; and used those coordinates for the vertexData array. Text, cleanup: Declaration of local variables outside of loops. Fixed indentation. Approved by PS Jenkins bot, Sam Spilsbury.
-
MC Return authored
Always bail out of function ASAP, do not calculate stuff you might not need. Declare variables outside of loops so they won't be re-declared in each loop. Use prefix instead of postfix increments. Declaration and assignment of variables in one line. Merged if condition checks. Added and removed brackets. Added and removed newlines, if appropriate. Minor code structure improvements, declare variables when you need them, not much earlier. Fixed indentation. Approved by PS Jenkins bot, Sam Spilsbury.
-
MC Return authored
Declare variables outside of loops. Declaration and assignment of local variables in one line. Use pre- instead of postfix increment. Removed redundant newlines. Removed redundant casts. (from (float) optionGetFireColor) Removed redundant brackets. Added missing break (style issue only). Added comment and TODO. Fixed indentation. Firepaint, speedup: We just enable GL_BLEND if it is disabled and we just disable GL_BLEND if it was disabled before. Introduced the GLfloats xMinusW, xPlusW, yMinusH and yPlusH to store calculated coordinates instead of recalculating them multiple times. Introduced float fireLife = optionGetFireLife ();, float fireWidth = optionGetFireSize ();, float fireHeight = fireWidth * 1.5f; and bool mystFire = optionGetFireMystical (); and used those variables inside the loop. Firepaint, .xml.in cleanup: Firepaint now has 2 tabs, 'General' and 'Particle Settings'. The name of this plugin is Firepaint, <short> should not contain the description. Better description of the plugin. Uppercase option titles. Punctuation for tooltips. Improved tooltips. Firepaint, fixes: Initialize all class member variables in the ParticleSystem:: ParticleSystem () ctor (LP: #1101512, LP: #1101580). Fixes: https://bugs.launchpad.net/bugs/1101512, https://bugs.launchpad.net/bugs/1101580. Approved by PS Jenkins bot, Sam Spilsbury.
-
MC Return authored
Declaration and assignment of local variables in one line. (this *should* fix bug #1101405) Use pre- instead of postfix increments. Added and removed newlines. Added missing break (just a style issue). Fixed indentation. (LP: #1101405). Fixes: https://bugs.launchpad.net/bugs/1101405. Approved by PS Jenkins bot, Sam Spilsbury.
-
BryanFRitt authored
Moved this option's CCSM position upwards to keep the button shortcuts together. (LP: #1202907). Fixes: https://bugs.launchpad.net/bugs/1202907. Approved by PS Jenkins bot, MC Return.
-
- Jul 19, 2013
-
-
Sami Jaktholm authored
If window is visible in the current viewport, use that viewport when calculating geometries in addWindowSizeChanges. Otherwise the current method is used. This way visible windows are maximized in the current viewport. However, offscreen windows won't jump back to the active viewport if window maximizes by itself or addWindowSizeChanges is called for some other reason. Fixes: https://bugs.launchpad.net/bugs/776435. Approved by PS Jenkins bot, Brandon Schaefer, Sam Spilsbury.
-
Sam Spilsbury authored
1. Always set frame extents before updating the frame 2. Added COMPIZ_NO_CONFIGURE_BUFFER_LOCKS so that we don't have to deal with the delayed configure requests logic in the tests where it does not help 3. Split restoredDecorationSize in to restoredDecorationBorderSize and restoredDecorationInputSize so that we can measure the size of the decoration both in terms of its visible and invisible border 4. Wait for the default decoration properly 5. Capture the initial geometry of the window with and without decorations when the window gets its first decoration. Use these values to calculate the size changes in the window from then on instead of its creation values 6. Just flag when the window was first decorated in setWindowFrameExtents rather than checking if it is mapped. We only want to not resize the window once. Approved by PS Jenkins bot, Sam Spilsbury, Andrea Azzarone.
-
Sami Jaktholm authored
If window is visible in the current viewport, use that viewport when calculating geometries in addWindowSizeChanges. Otherwise the current method is used. This way visible windows are maximized in the current viewport. However, offscreen windows won't jump back to the active viewport if window maximizes by itself or addWindowSizeChanges is called for some other reason.
-
Sam Spilsbury authored
-
BryanFRitt authored
-
- Jul 18, 2013
-
-
Sam Spilsbury authored
(LP: #1067246). Fixes: https://bugs.launchpad.net/bugs/1067246. Approved by PS Jenkins bot, Sam Spilsbury.
-
Sam Spilsbury authored
In the event that a window is unreparented or destroyed, we usually need to add its frame window to the toplevel window stack until the time at which we recieve a DestroyNotify for it, as there may be incoming ConfigureNotify events puporting to stack other windows relative to that frame. However, this does not apply in the case where we have not yet received a CreateNotify for the frame window. In that case, it is not possible for any stacking requests to be made relative to this window, so it does not need to be added immediately. Instead, we can add it at the time that we recieve a CreateNotify for it as a regular override redirect window until the time that it is later destroyed. (LP: #1171314). Fixes: https://bugs.launchpad.net/bugs/1171314. Approved by PS Jenkins bot, MC Return.
-
Brandon Schaefer authored
If we receive a stateNotifyChange, we check if we are in a max state. If so, overwrite the xwc with either X | W, or Y | H depending on the semi max state with the orig position before we went into a semi max state. This way when we leave any sort of max state the orig position is restored. If the window is being grabbed we do not overwrite the position, which it gets its own value at that point (instead of the orig pos). Fixes: https://bugs.launchpad.net/bugs/892012. Approved by PS Jenkins bot, Sam Spilsbury, MC Return, Sami Jaktholm.
-
Andrea Azzarone authored
(LP: #1198000). Fixes: https://bugs.launchpad.net/bugs/1198000. Approved by PS Jenkins bot, Sam Spilsbury, MC Return.
-
Sam Spilsbury authored
-
Sam Spilsbury authored
-
Sam Spilsbury authored
Port to new gmock. Disable some faling tests because of weird leaks. Fixes: https://bugs.launchpad.net/bugs/1185265. Approved by PS Jenkins bot, Brandon Schaefer.
-
- Jul 17, 2013
-
-
Andrea Azzarone authored
-
Sam Spilsbury authored
-
Sam Spilsbury authored
-
Sam Spilsbury authored
of the gmock headers dynamically, and only build gmock if they are found.
-
Sam Spilsbury authored
-
Sam Spilsbury authored
type from the setting in order to free it properly, just use a stub. Because the stub can store data properly, we don't need to worry about keeping around a copy of the list info anymore.
-
Sam Spilsbury authored
-
Sam Spilsbury authored
-
- Jul 16, 2013
-
-
Andrea Azzarone authored
-
Andrea Azzarone authored
-
- Jul 15, 2013
-
-
Sam Spilsbury authored
-
Sam Spilsbury authored
-
Sam Spilsbury authored
-
Sam Spilsbury authored
-
Sam Spilsbury authored
-
Andrea Azzarone authored
-
Sam Spilsbury authored
1. Always set frame extents before updating the frame 2. Added COMPIZ_NO_CONFIGURE_BUFFER_LOCKS so that we don't have to deal with the delayed configure requests logic in the tests where it does not help 3. Split restoredDecorationSize in to restoredDecorationBorderSize and restoredDecorationInputSize so that we can measure the size of the decoration both in terms of its visible and invisible border 4. Wait for the default decoration properly 5. Capture the initial geometry of the window with and without decorations when the window gets its first decoration. Use these values to calculate the size changes in the window from then on instead of its creation values 6. Just flag when the window was first decorated in setWindowFrameExtents rather than checking if it is mapped. We only want to not resize the window once.
-
Sam Spilsbury authored
-
- Jul 14, 2013
-
-
Sami Jaktholm authored
-
- Jul 12, 2013
-
-
Brandon Schaefer authored
regression... but that doesn't mean there arent!
-
- Jul 11, 2013
-
-
Brandon Schaefer authored
-