- Jan 24, 2013
-
-
Daniel van Vugt authored
. Approved by Brandon Schaefer.
-
- Jan 23, 2013
-
-
Didier Roche authored
Really take default patched hsize and vsize and don't override them to fix (LP: #868423). Fixes: https://bugs.launchpad.net/bugs/868423. Approved by PS Jenkins bot, Daniel van Vugt.
-
MC Return authored
Showmouse: Limit particle life to 0.9490 to ensure that the emitters are always able to follow the mousepointer, even at extreme settings. (LP: #1098877). Fixes: https://bugs.launchpad.net/bugs/1098877. Approved by Daniel van Vugt.
-
sampo555 authored
Changes include: 1) Remove the special status of fully maximized windows - it just adds complexity to the restoration process. Core can handle the restoration of maximized windows perfectly well. 2) Catch un-maximation of a gridded semi-maximized window in stateChangeNotify and call restoreWindow to revert the changes. 3) Refactor restoreWindow to work with semi-maximized windows. This fixes LP: #878516 and also LP: #925867 as a side effect. Fixes: https://bugs.launchpad.net/bugs/878516, https://bugs.launchpad.net/bugs/925867. Approved by Daniel van Vugt, MC Return.
-
Didier Roche authored
to fix (LP: #868423)
-
Daniel van Vugt authored
fixes to land yet...
-
sampo555 authored
-
Daniel van Vugt authored
The previous attempt (LP: #1097649) had no effect because valgrind requires suppression rules match the function at the top of the stack explicitly (calloc/malloc...). So that's what I've added here, and now it works. . Fixes: https://bugs.launchpad.net/bugs/1102822. Approved by Sam Spilsbury, PS Jenkins bot.
-
Daniel van Vugt authored
I think, and likely one-time. (LP: #1102829). Fixes: https://bugs.launchpad.net/bugs/1102829. Approved by PS Jenkins bot, Sam Spilsbury.
-
- Jan 22, 2013
-
-
MC Return authored
(LP: #1101558). Fixes: https://bugs.launchpad.net/bugs/1101558. Approved by Daniel van Vugt.
-
MC Return authored
Showmouse: Limit particle life to 0.9490 to ensure that the emitters are able to follow the mousepointer, even at extreme settings
-
MC Return authored
Added missing break to ccpInitValue (CCSSettingValue *value, CompOption::Value *from, CCSSettingType type) function. (LP: #1101557). Fixes: https://bugs.launchpad.net/bugs/1101557. Approved by Daniel van Vugt.
-
sampo555 authored
-
MC Return authored
(LP: #1101465). Fixes: https://bugs.launchpad.net/bugs/1101465. Approved by Daniel van Vugt.
-
Sam Spilsbury authored
(LP: #1100564). Fixes: https://bugs.launchpad.net/bugs/1100564. Approved by Daniel van Vugt.
-
Daniel van Vugt authored
I think, and likely one-time. (LP: #1102829)
-
MC Return authored
(LP: #1101430). Fixes: https://bugs.launchpad.net/bugs/1101430. Approved by Daniel van Vugt.
-
Daniel van Vugt authored
The previous attempt (LP: #1097649) had no effect because valgrind requires suppression rules match the function at the top of the stack explicitly (calloc/malloc...). So that's what I've added here, and now it works.
-
- Jan 21, 2013
-
-
sampo555 authored
isGridMaximized changed to isGridSemiMaximized and comment added about core handling fully maximized windows. Added assert to the else clause in restoreWindow, changed shifts to divide by 2 and added check for xwcm before calling sendSyncRequest. Also added an extra check so that we only call restoreWindow from stateChangeNotify if lastState was CompWindowStateMaximizedVertMask (e.g. not a fully maximized window incorrectly marked as isGridSemiMaximized).
-
Automatic PS uploader authored
Approved by .
-
Automatic PS uploader authored
-
- Jan 20, 2013
-
-
sampo555 authored
Changes include: 1) Remove the special status of fully maximized windows - it just adds complexity to the restoration process. Core can handle the restoration of maximized windows perfectly well. 2) Catch un-maximation of a gridded semi-maximized window in stateChangeNotify and call restoreWindow to revert the changes. 3) Refactor restoreWindow to work with semi-maximized windows. This fixes bug 878516 and also bug 925867 as a side effect.
-
- Jan 19, 2013
-
-
MC Return authored
-
MC Return authored
Added missing break to ccpInitValue (CCSSettingValue *value, CompOption::Value *from, CCSSettingType type) function
-
MC Return authored
-
MC Return authored
-
Sam Spilsbury authored
Don't set _NET_DESKTOP_GEOMETRY until we've set the default viewport size. (LP: #1096455). Fixes: https://bugs.launchpad.net/bugs/1096455. Approved by Daniel van Vugt, PS Jenkins bot.
-
Brandon Schaefer authored
renders it to the growing grid box and slowly fades out into the default orange glow box. Also adds 2 options ccsm for the grid, one to turn this animation off, and another to change the grid animation duration. This also changes the default grid duration from 250 ms, to 350ms. (LP: #689792). Fixes: https://bugs.launchpad.net/bugs/689792. Approved by Daniel van Vugt, PS Jenkins bot, Brandon Schaefer, MC Return.
-
- Jan 18, 2013
-
-
Brandon Schaefer authored
-
Sam Spilsbury authored
(LP: #1097649). Fixes: https://bugs.launchpad.net/bugs/1097649. Approved by Daniel van Vugt, PS Jenkins bot.
-
Sam Spilsbury authored
run_command_* keys as well, since they don't use the standard storage
-
Sam Spilsbury authored
auto-free them in the tests. (LP: #1100539). Fixes: https://bugs.launchpad.net/bugs/1100539. Approved by Daniel van Vugt, PS Jenkins bot.
-
Brandon Schaefer authored
* Moved from glPaint to glDraw * Move glDrawSetEnabled(ture/false) to ::preparePaint and ::donePaint, so if it hits a donePaint, and never hits the prepartPaint it will stop drawing.
-
- Jan 17, 2013
-
-
Automatic PS uploader authored
Approved by .
-
Brandon Schaefer authored
-
Sam Spilsbury authored
-
Sam Spilsbury authored
[==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from CCSGNOMEIntegrationTestReadIntegrated [ RUN ] CCSGNOMEIntegrationTestReadIntegrated.TestReadInKeyOption [ OK ] CCSGNOMEIntegrationTestReadIntegrated.TestReadInKeyOption (497 ms) [----------] 1 test from CCSGNOMEIntegrationTestReadIntegrated (508 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (545 ms total) [ PASSED ] 1 test. ==28512== ==28512== HEAP SUMMARY: ==28512== in use at exit: 0 bytes in 0 blocks ==28512== total heap usage: 1,200 allocs, 1,200 frees, 144,800 bytes allocated ==28512== ==28512== All heap blocks were freed -- no leaks are possible ==28512== ==28512== For counts of detected and suppressed errors, rerun with: -v ==28512== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 2 from 2)
-
Sam Spilsbury authored
[==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from CCSGNOMEIntegrationTestReadIntegrated [ RUN ] CCSGNOMEIntegrationTestReadIntegrated.TestReadInKeyOption [ OK ] CCSGNOMEIntegrationTestReadIntegrated.TestReadInKeyOption (497 ms) [----------] 1 test from CCSGNOMEIntegrationTestReadIntegrated (509 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (552 ms total) [ PASSED ] 1 test. ==28295== ==28295== HEAP SUMMARY: ==28295== in use at exit: 11 bytes in 1 blocks ==28295== total heap usage: 1,200 allocs, 1,199 frees, 144,800 bytes allocated ==28295== ==28295== 11 bytes in 1 blocks are definitely lost in loss record 1 of 1 ==28295== at 0x4C2CD7B: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==28295== by 0x5D31961: strdup (strdup.c:42) ==28295== by 0x4EC353: CCSGNOMEIntegrationTestReadIntegrated_TestReadInKeyOption_Test::TestBody() (compizconfig_test_ccs_gnome_integration.cpp:347) ==28295== by 0x51EC59: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (gtest.cc:2090) ==28295== by 0x513A68: testing::Test::Run() (gtest.cc:2162) ==28295== by 0x513B46: testing::TestInfo::Run() (gtest.cc:2338) ==28295== by 0x513C84: testing::TestCase::Run() (gtest.cc:2445) ==28295== by 0x513F0C: testing::internal::UnitTestImpl::RunAllTests() (gtest.cc:4243) ==28295== by 0x51E7D9: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (gtest.cc:2090) ==28295== by 0x5132C0: testing::UnitTest::Run() (gtest.cc:3880) ==28295== by 0x4E8768: main (gtest_main.cc:38) ==28295== ==28295== LEAK SUMMARY: ==28295== definitely lost: 11 bytes in 1 blocks ==28295== indirectly lost: 0 bytes in 0 blocks ==28295== possibly lost: 0 bytes in 0 blocks ==28295== still reachable: 0 bytes in 0 blocks ==28295== suppressed: 0 bytes in 0 blocks
-
Sam Spilsbury authored
Make freeing the returned lists the responsibility of the caller. Don't auto-free them in the tests. (LP: #1100539)
-
Automatic PS uploader authored
-