warning: implicit conversion from ‘gfloat {aka float}’ to ‘double’
to match other operand of binary expression [-Wdouble-promotion]

warning: implicit conversion from ‘float’ to ‘double’ to match
other operand of binary expression [-Wdouble-promotion]

warning: implicit conversion from ‘float’ to ‘double’ to match
other operand of binary expression [-Wdouble-promotion]

Set the NET_WM_STATE_FOCUSED property on windows of type dock or
spashscreen so that they don't get the state GTK_STATE_FLAG_BACKDROP
set by default.

Based on xfwm4 commit:
https://git.xfce.org/xfce/xfwm4/commit/?id=0feb29e78bb3

If window is not client side decorated then we should add shadow
also when using GTK+ theme.

https://bugzilla.gnome.org/show_bug.cgi?id=789251

Rui Matos authored May 19, 2017 and Alberts Muktupāvels committed Sep 30, 2017

https://git.gnome.org/browse/mutter/commit/?id=e3d5bc07
https://bugzilla.gnome.org/show_bug.cgi?id=780485

Florian Müllner authored Sep 28, 2017 and Alberts Muktupāvels committed Sep 30, 2017

Otherwise we may try to remove the now invalid ID again, resulting
in a warning.

https://bugzilla.gnome.org/show_bug.cgi?id=788292

g_set_object increments reference count of new_object.

https://bugzilla.gnome.org/show_bug.cgi?id=788078

https://bugzilla.gnome.org/show_bug.cgi?id=603510

this statement may fall through [-Wimplicit-fallthrough=]

We are not using return value from meta_error_trap_pop_with_return
if keyboard grab has failed, replace it with meta_error_trap_pop.

Colin Walters authored Aug 06, 2009 and Alberts Muktupāvels committed Jul 21, 2017

g_new bad, g_new0 good.

Owen W. Taylor authored Feb 09, 2010 and Alberts Muktupāvels committed Jul 21, 2017

Since meta_workspace_invalidate_work_area() frees the edges
workspace->screen_edges and workspace->monitor_edges, we must clean up
our cached edge resistance data when the invalidate_work_area() is
called on the active workspace, or when the workspace changes.

Make the computation of the edge resistance data lazy so that it
will be recomputed the next time we try to access it.
meta_display_compute_resistance_and_snapping_edges() is made
private to edge-resistance.c

Invaliding the data when active workspace changes also will improve
correctness for edge resistance when the current workspace changes
during a grab operation. (Even with this fix we still don't try to
handle window positions changing during a grab operation; that can't
cause a crash since, unlike screen and monitor edges, the window edges
are freshly allocated, it will just cause slight oddness in that
corner case.)

Root cause tracked down due to much effort by Jon Nettleton.
https://bugzilla.gnome.org/show_bug.cgi?id=608800 (Mutter)
https://bugzilla.gnome.org/show_bug.cgi?id=603632 (Metacity)

Owen W. Taylor authored Nov 20, 2009 and Alberts Muktupāvels committed Jul 21, 2017

Treat the empty string the same as "disabled" for GConf keybinding
keys. gnome-keybinding-properties was changed to write disabled
keys as the empty string a year or so ago.

https://bugzilla.gnome.org/show_bug.cgi?id=559816