Skip to content
control-enter 1.24 KiB
Newer Older
Samuel Thibault's avatar
Samuel Thibault committed
commit b2d9ab56ace0f4ceeac9e0d23f8c09e4cd70f2b6
Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
Date:   Fri Feb 15 14:45:18 2019 +0100

    atk key: Always convert control character events into key names

    including when the control modifier is present, i.e. when one is typing
    control-I for instance.

    Orca would convert them back to the corresponding ASCII letter anyway, and
    when pressing control-tab, we do want to pass "tab", not pass "\t" that Orca
    would erroneously convert to "control-I".

Index: firefox-esr-60.5.1esr-1/accessible/atk/UtilInterface.cpp
===================================================================
--- firefox-esr-60.5.1esr-1.orig/accessible/atk/UtilInterface.cpp
+++ firefox-esr-60.5.1esr-1/accessible/atk/UtilInterface.cpp
@@ -161,8 +161,7 @@ static AtkKeyEventStruct *atk_key_event_
   event->keyval = key->keyval;
   event->length = key->length;
   if (key->string && key->string[0] &&
-      (key->state & GDK_CONTROL_MASK ||
-       g_unichar_isgraph(g_utf8_get_char(key->string)))) {
+      g_unichar_isgraph(g_utf8_get_char(key->string))) {
     event->string = key->string;
   } else if (key->type == GDK_KEY_PRESS || key->type == GDK_KEY_RELEASE) {
     event->string = gdk_keyval_name(key->keyval);