From 265484bf3c7c01508475a1e015a1c6ce8694c373 Mon Sep 17 00:00:00 2001 From: Samuel Thibault Date: Thu, 21 Feb 2019 11:28:53 +0100 Subject: [PATCH] Add fix for bogus zoom movement on empty entry --- firefox-patches/patches-60/blur | 2 ++ firefox-patches/patches-60/control-enter | 4 +++ firefox-patches/patches-60/entry-empty | 30 ++++++++++++++++++++ firefox-patches/patches-60/jumpedline | 2 ++ firefox-patches/patches-60/scrollsubstringto | 2 ++ firefox-patches/patches-60/scrollto | 2 ++ firefox-patches/patches-60/setcaret | 2 ++ firefox-patches/patches-60/twisties | 2 ++ firefox-patches/series-60 | 1 + firefox-patches/version | 2 +- thunderbird-patches/patches-52/control-enter | 2 ++ thunderbird-patches/patches-60/control-enter | 2 ++ 12 files changed, 52 insertions(+), 1 deletion(-) create mode 100644 firefox-patches/patches-60/entry-empty diff --git a/firefox-patches/patches-60/blur b/firefox-patches/patches-60/blur index 1db746b..e643250 100644 --- a/firefox-patches/patches-60/blur +++ b/firefox-patches/patches-60/blur @@ -1,5 +1,7 @@ Fix tab focus when tabbing through an element that refuses focus +Fix pending commiting + # HG changeset patch # User Neil Deakin # Parent 76376169669fbc390d1cd297d4a3412f15f68461 diff --git a/firefox-patches/patches-60/control-enter b/firefox-patches/patches-60/control-enter index 8712339..b9cb012 100644 --- a/firefox-patches/patches-60/control-enter +++ b/firefox-patches/patches-60/control-enter @@ -1,3 +1,7 @@ +Fix announce of control-enter, control-tab, etc + +Fix pending submission and commiting to gtk before submitting to firefox & thunderbird + commit b2d9ab56ace0f4ceeac9e0d23f8c09e4cd70f2b6 Author: Samuel Thibault Date: Fri Feb 15 14:45:18 2019 +0100 diff --git a/firefox-patches/patches-60/entry-empty b/firefox-patches/patches-60/entry-empty new file mode 100644 index 0000000..9cdfe63 --- /dev/null +++ b/firefox-patches/patches-60/entry-empty @@ -0,0 +1,30 @@ +Fix bogus zoom movement when entry is empty + +Integrated in firefox 62 + +# HG changeset patch +# User Samuel Thibault +# Date 1527087753 -7200 +# Wed May 23 17:02:33 2018 +0200 +# Branch 0-0-text-empty +# Node ID 671db2eaa822daab7d15c25d4aab3b793a0a457f +# Parent d36cd8bdbc5c0df1d1d7a167f5fedb95c3a3648e +Bug 1319273 Accessible: Make TextBounds return rect of whole frame if content is empty r=asurkov + +diff --git a/accessible/generic/HyperTextAccessible.cpp b/accessible/generic/HyperTextAccessible.cpp +--- a/accessible/generic/HyperTextAccessible.cpp ++++ b/accessible/generic/HyperTextAccessible.cpp +@@ -1178,6 +1178,13 @@ HyperTextAccessible::TextBounds(int32_t + return nsIntRect(); + } + ++ if (CharacterCount() == 0) { ++ nsPresContext* presContext = mDoc->PresContext(); ++ // Empty content, use our own bound to at least get x,y coordinates ++ return GetFrame()->GetScreenRectInAppUnits(). ++ ToNearestPixels(presContext->AppUnitsPerDevPixel()); ++ } ++ + int32_t childIdx = GetChildIndexAtOffset(startOffset); + if (childIdx == -1) return nsIntRect(); + diff --git a/firefox-patches/patches-60/jumpedline b/firefox-patches/patches-60/jumpedline index e1ce087..5b69e01 100644 --- a/firefox-patches/patches-60/jumpedline +++ b/firefox-patches/patches-60/jumpedline @@ -1,5 +1,7 @@ Fix word navigation around warped lines +Being rewritten + # HG changeset patch # User Samuel Thibault # Date 1548856422 -3600 diff --git a/firefox-patches/patches-60/scrollsubstringto b/firefox-patches/patches-60/scrollsubstringto index 23c6552..0e7d01b 100644 --- a/firefox-patches/patches-60/scrollsubstringto +++ b/firefox-patches/patches-60/scrollsubstringto @@ -1,5 +1,7 @@ Support scrollsubstringto ATK API +Integrated in firefox 66 + # HG changeset patch # User Samuel Thibault # Date 1548531533 -3600 diff --git a/firefox-patches/patches-60/scrollto b/firefox-patches/patches-60/scrollto index 63ad55b..3fa52d4 100644 --- a/firefox-patches/patches-60/scrollto +++ b/firefox-patches/patches-60/scrollto @@ -1,5 +1,7 @@ Support scrollto ATK API +Integrated in firefox 62 + # HG changeset patch # User Samuel Thibault # Date 1525269333 -7200 diff --git a/firefox-patches/patches-60/setcaret b/firefox-patches/patches-60/setcaret index 71041cf..3c172c9 100644 --- a/firefox-patches/patches-60/setcaret +++ b/firefox-patches/patches-60/setcaret @@ -1,5 +1,7 @@ Work around text offset issue around list bullets +Still ongoing work + # HG changeset patch # User Samuel Thibault # Date 1533116635 -7200 diff --git a/firefox-patches/patches-60/twisties b/firefox-patches/patches-60/twisties index ed70d3c..a943f0c 100644 --- a/firefox-patches/patches-60/twisties +++ b/firefox-patches/patches-60/twisties @@ -1,5 +1,7 @@ Fix visibility of twisties +Integrated in firefox 63 + Bug 1376756 gtk: while drawing nsTreeBodyFrame, fetch current row attributes for proper style rendering r=karlt --- diff --git a/firefox-patches/series-60 b/firefox-patches/series-60 index ac5df2c..42b676a 100644 --- a/firefox-patches/series-60 +++ b/firefox-patches/series-60 @@ -1,3 +1,4 @@ +entry-empty twisties blur #setcaret diff --git a/firefox-patches/version b/firefox-patches/version index 0cfbf08..00750ed 100644 --- a/firefox-patches/version +++ b/firefox-patches/version @@ -1 +1 @@ -2 +3 diff --git a/thunderbird-patches/patches-52/control-enter b/thunderbird-patches/patches-52/control-enter index a84de0b..1f39bef 100644 --- a/thunderbird-patches/patches-52/control-enter +++ b/thunderbird-patches/patches-52/control-enter @@ -1,3 +1,5 @@ +Fix announce of control-enter, control-tab, etc + commit b2d9ab56ace0f4ceeac9e0d23f8c09e4cd70f2b6 Author: Samuel Thibault Date: Fri Feb 15 14:45:18 2019 +0100 diff --git a/thunderbird-patches/patches-60/control-enter b/thunderbird-patches/patches-60/control-enter index e5129c5..d1007aa 100644 --- a/thunderbird-patches/patches-60/control-enter +++ b/thunderbird-patches/patches-60/control-enter @@ -1,3 +1,5 @@ +Fix announce of control-enter, control-tab, etc + commit b2d9ab56ace0f4ceeac9e0d23f8c09e4cd70f2b6 Author: Samuel Thibault Date: Fri Feb 15 14:45:18 2019 +0100 -- GitLab